linux-kernel - Re: [PATCH] kunit: tool: fix --raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS_qxpr1XiqcGPcfxnsAuxqnyJ0K+0UF-q146oQjsQqyHbm9g@mail.gmail.com>
Date:   Fri, 30 Oct 2020 11:12:11 -0700
From:   Daniel Latypov <dlatypov@...gle.com>
To:     David Gow <davidgow@...gle.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: tool: fix --raw_output to actually show output

On Fri, Oct 30, 2020 at 12:23 AM David Gow <davidgow@...gle.com> wrote:
>
> On Fri, Oct 30, 2020 at 2:17 PM Daniel Latypov <dlatypov@...gle.com> wrote:
> >
> > Currently --raw_output means nothing gets shown.
> > Why?
> > Because `raw_output()` has a `yield` and therefore is a generator, which
> > means it only executes when you ask it for a value.
> >
> > Given no one actually is using it as a generator (checked via the added
> > type annotation), drop the yield so we actually print the output.
> >
> > Also strip off the trailing \n (and any other whitespace) to avoid
> >   [<601d6d3a>] ? printk+0x0/0x9b
> >
> >   [<601e5058>] ? kernel_init+0x23/0x14b
> >
> >   [<600170d2>] ? new_thread_handler+0x82/0xc0
> > making the output unreadable.
> >
> > Signed-off-by: Daniel Latypov <dlatypov@...gle.com>
> > ---
>
> The bug where --raw_output doesn't show anything is already fixed[1],
> but it does still show the extra newlines.

I'm not sure how I missed that, sorry for the noise.

>
> Maybe it's worth making just the newline fix, and rolling it into the
> other patch[2] handling newlines?

Sounds good.

>
> Cheers,
> -- David
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit-fixes&id=3023d8ff3fc60e5d32dc1d05f99ad6ffa12b0033
> [2]: https://lore.kernel.org/linux-kselftest/20201020233219.4146059-1-dlatypov@google.com/