linux-kernel - Re: [PATCH] ASoC: qcom: MSM8996 depends on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a55d71fd-d5b1-26f9-c3f0-7f2ff91bef07@infradead.org>
Date:   Fri, 30 Oct 2020 11:31:25 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        Mark Brown <broonie@...nel.org>
Cc:     Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH] ASoC: qcom: MSM8996 depends on COMMON_CLK

On 10/16/20 10:39 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix a kconfig warning in sound/soc/qcom:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
>   Selected by [y]:
>   - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]
> 
> This is needed because 'select' does not follow dependency chains.
> 
> Fixes: a6f933f63f2f ("ASoC: qcom: apq8096: Add db820c machine driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: alsa-devel@...a-project.org
> ---
> Found in linux-next but applies to mainline.
> 
>  sound/soc/qcom/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20201016.orig/sound/soc/qcom/Kconfig
> +++ linux-next-20201016/sound/soc/qcom/Kconfig
> @@ -106,6 +106,7 @@ config SND_SOC_QDSP6
>  config SND_SOC_MSM8996
>  	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
>  	depends on QCOM_APR
> +	depends on COMMON_CLK
>  	select SND_SOC_QDSP6
>  	select SND_SOC_QCOM_COMMON
>  	help
> 

Ping. I am still seeing this kconfig warning in linux-next 20201030.

-- 
~Randy