lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Oct 2020 12:46:26 -0600 From: Jens Axboe <axboe@...nel.dk> To: Al Viro <viro@...iv.linux.org.uk>, Qian Cai <cai@...hat.com> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths On 10/30/20 12:42 PM, Al Viro wrote: > On Fri, Oct 30, 2020 at 11:24:07AM -0400, Qian Cai wrote: >> We will need to call putname() before do_renameat2() returning -EINVAL >> to avoid memory leaks. >> >> Fixes: 3c5499fa56f5 ("fs: make do_renameat2() take struct filename") >> Signed-off-by: Qian Cai <cai@...hat.com> > > May I ask where has the original commit been posted for review? And why > the bleeding hell does io_uring touch rename-related codepaths in the > first place? See other reply, it's being posted soon, just haven't gotten there yet and it wasn't ready. It's a prep patch so we can call do_renameat2 and pass in a filename instead. The intent is not to have any functional changes in that prep patch. But once we can pass in filenames instead of user pointers, it's usable from io_uring. I'll post this as soon as I get around to it, it's been on the back burner for the last month or so. -- Jens Axboe
Powered by blists - more mailing lists