linux-kernel - Re: [PATCH RFC v2 2/4] x86/bus_lock: Handle warn and fatal in #DB for bus lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030193955.GA3568909@otcwcpicx6.sc.intel.com>
Date:   Fri, 30 Oct 2020 19:39:55 +0000
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        Tony Luck <tony.luck@...el.com>,
        Christopherson Sean J <sean.j.christopherson@...el.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH RFC v2 2/4] x86/bus_lock: Handle warn and fatal in #DB
 for bus lock

Hi, PeterZ,

On Thu, Oct 29, 2020 at 10:27:47AM +0100, Peter Zijlstra wrote:
> On Wed, Oct 28, 2020 at 08:28:02PM +0000, Fenghua Yu wrote:
> > diff --git a/arch/x86/include/uapi/asm/debugreg.h b/arch/x86/include/uapi/asm/debugreg.h
> > index d95d080b30e3..61078319fc6c 100644
> > --- a/arch/x86/include/uapi/asm/debugreg.h
> > +++ b/arch/x86/include/uapi/asm/debugreg.h
> > @@ -16,7 +16,7 @@
> >     are either reserved or not of interest to us. */
> >  
> >  /* Define reserved bits in DR6 which are always set to 1 */
> > -#define DR6_RESERVED	(0xFFFF0FF0)
> > +#define DR6_RESERVED	(0xFFFF07F0)
> 
> NAK

You are right. I will remove this piece of code in the next version.

Thank you very much for your review!

-Fenghua