linux-kernel - Re: [PATCH] percpu: convert flexible array initializers to use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04b2a0ec-4b2e-60d2-5f7b-26d07b93a88d@embeddedor.com>
Date:   Fri, 30 Oct 2020 16:38:37 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Dennis Zhou <dennis@...nel.org>, Tejun Heo <tj@...nel.org>,
        Christoph Lameter <cl@...ux.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] percpu: convert flexible array initializers to use
 struct_size()



On 10/30/20 15:58, Dennis Zhou wrote:
> Use the safer macro as sparked by the long discussion in [1].
> 
> [1] https://lore.kernel.org/lkml/20200917204514.GA2880159@google.com/
> 
> Signed-off-by: Dennis Zhou <dennis@...nel.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
--
Gustavo

> ---
> I'll apply it to for-5.10-fixes.
> 
>  mm/percpu.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/percpu.c b/mm/percpu.c
> index 66a93f096394..ad7a37ee74ef 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -1315,8 +1315,8 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr,
>  	region_size = ALIGN(start_offset + map_size, lcm_align);
>  
>  	/* allocate chunk */
> -	alloc_size = sizeof(struct pcpu_chunk) +
> -		BITS_TO_LONGS(region_size >> PAGE_SHIFT) * sizeof(unsigned long);
> +	alloc_size = struct_size(chunk, populated,
> +				 BITS_TO_LONGS(region_size >> PAGE_SHIFT));
>  	chunk = memblock_alloc(alloc_size, SMP_CACHE_BYTES);
>  	if (!chunk)
>  		panic("%s: Failed to allocate %zu bytes\n", __func__,
> @@ -2521,8 +2521,8 @@ void __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai,
>  	pcpu_unit_pages = ai->unit_size >> PAGE_SHIFT;
>  	pcpu_unit_size = pcpu_unit_pages << PAGE_SHIFT;
>  	pcpu_atom_size = ai->atom_size;
> -	pcpu_chunk_struct_size = sizeof(struct pcpu_chunk) +
> -		BITS_TO_LONGS(pcpu_unit_pages) * sizeof(unsigned long);
> +	pcpu_chunk_struct_size = struct_size(chunk, populated,
> +					     BITS_TO_LONGS(pcpu_unit_pages));
>  
>  	pcpu_stats_save_ai(ai);
>  
>