linux-kernel - [PATCH v2 2/2] iommu/vt-d: Fix a bug for PDP check in prq_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1604025444-6954-3-git-send-email-yi.y.sun@linux.intel.com>
Date:   Fri, 30 Oct 2020 10:37:24 +0800
From:   Yi Sun <yi.y.sun@...ux.intel.com>
To:     joro@...tes.org, dwmw2@...radead.org, baolu.lu@...ux.intel.com,
        jean-philippe@...aro.org
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        yi.l.liu@...el.com, jacob.jun.pan@...ux.intel.com,
        Liu@...r.kernel.org, Yi Sun <yi.y.sun@...ux.intel.com>
Subject: [PATCH v2 2/2] iommu/vt-d: Fix a bug for PDP check in prq_event_thread

From: "Liu, Yi L" <yi.l.liu@...el.com>

In prq_event_thread(), the QI_PGRP_PDP is wrongly set by
'req->pasid_present' which should be replaced to
'req->priv_data_present'.

Fixes: 5b438f4ba315 ("iommu/vt-d: Support page request in scalable mode")
Signed-off-by: Liu, Yi L <yi.l.liu@...el.com>
Signed-off-by: Yi Sun <yi.y.sun@...ux.intel.com>
---
 drivers/iommu/intel/svm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index 7584669..3242ebd 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -1035,7 +1035,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
 			resp.qw0 = QI_PGRP_PASID(req->pasid) |
 				QI_PGRP_DID(req->rid) |
 				QI_PGRP_PASID_P(req->pasid_present) |
-				QI_PGRP_PDP(req->pasid_present) |
+				QI_PGRP_PDP(req->priv_data_present) |
 				QI_PGRP_RESP_CODE(result) |
 				QI_PGRP_RESP_TYPE;
 			resp.qw1 = QI_PGRP_IDX(req->prg_index) |
-- 
2.7.4