linux-kernel - Re: [PATCH] memory: pl353-smc: fix compile test on !ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7fd6b14a-6a27-50cf-2232-4c9c00a3b35c@xilinx.com>
Date:   Fri, 30 Oct 2020 07:59:13 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        <naga.sureshkumar.relli@...inx.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA



On 30. 10. 20 1:40, Nick Desaulniers wrote:
> + authors/reviewers of commit fee10bd22678 ("memory: pl353: Add driver
> for arm pl353 static memory controller")
> 
> On Thu, Oct 29, 2020 at 12:34 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> The pl353-smc driver uses module_amba_driver so it has a build
>> dependency on CONFIG_ARM_AMBA:
>>
>>     /usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
>>     pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'
>>
>> However it still can be compile tested on platforms other than ARM,
>> which in practice is limited to those selecting ARM_AMBA (so only
>> ARM64).

Indeed.

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal