linux-kernel - RE: [PATCH 1/3] Input: goodix - add option to disable firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR10MB3977AD402979E266661DB9FD92150@DB8PR10MB3977.EURPRD10.PROD.OUTLOOK.COM>
Date:   Fri, 30 Oct 2020 08:45:22 +0000
From:   "Valek, Andrej" <andrej.valek@...mens.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Hans de Goede <hdegoede@...hat.com>
CC:     "nick@...anahar.org" <nick@...anahar.org>,
        "hadess@...ess.net" <hadess@...ess.net>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH 1/3] Input: goodix - add option to disable firmware
 loading

Hello Dmitry,

No, I don't think so, that this is the case. Because, when I disabled the FW configuration loading device is working as well. To be honest, I don't need a new configuration for each boot 😊.

Regards,
Andrej

> Hi Andrej,
>
> On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote:
> > Firmware file loadind for GT911 controller takes too much time (~60s).
> > There is no check that configuration is the same which is already present.
> > This happens always during boot, which makes touchscreen unusable.
> >
> > Add there an option to prevent firmware file loading, but keep it
> > enabled by default.
>
> I thought that Goodix was losing firmware loading at poweroff. Is this not the case with this model?
>
> Adding Hans as he was working with this driver/code.
>
> >
> > Signed-off-by: Andrej Valek <andrej.valek@...mens.com>
> > ---
> >  drivers/input/touchscreen/goodix.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/goodix.c
> > b/drivers/input/touchscreen/goodix.c
> > index 02c75ea385e08..44336ecd2acdf 100644
> > --- a/drivers/input/touchscreen/goodix.c
> > +++ b/drivers/input/touchscreen/goodix.c
> > @@ -941,7 +941,9 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts)
> >  	default:
> >  		if (ts->gpiod_int && ts->gpiod_rst) {
> >  			ts->reset_controller_at_probe = true;
> > -			ts->load_cfg_from_disk = true;
> > +			/* Prevent cfg loading for each start */
> > +			ts->load_cfg_from_disk = !device_property_read_bool(dev,
> > +						 "touchscreen-do-not-load-fw");
> >  			ts->irq_pin_access_method = IRQ_PIN_ACCESS_GPIO;
> >  		}
> >  	}
> > --
> > 2.20.1
> >
>
> Thanks.
>
> --
> Dmitry