[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4644b6ca-ecc9-191f-c335-9c6d692ef38c@xs4all.nl>
Date: Fri, 30 Oct 2020 10:46:45 +0100
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Yu Kuai <yukuai3@...wei.com>, rick.chang@...iatek.com,
bin.liu@...iatek.com, mchehab@...nel.org, matthias.bgg@...il.com,
tiffany.lin@...iatek.com, andrew-ct.chen@...iatek.com,
tfiga@...omium.org, xia.jiang@...iatek.com, jcliang@...omium.org,
minghsiu.tsai@...iatek.com
Cc: linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
yi.zhang@...wei.com
Subject: Re: [PATCH 2/7] media: platform: add missing put_device() call in
mtk_jpeg_probe()
On 09/10/2020 14:37, Yu Kuai wrote:
> if mtk_jpeg_clk_init() succeed, mtk_jpeg_probe() doesn't have a
> corresponding put_device(). Thus add put_device() in jump target to fix
> the exception handling for this function implementation.
>
> Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index 106543391c46..f0c412f96d61 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1436,6 +1436,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
> v4l2_device_unregister(&jpeg->v4l2_dev);
>
> err_dev_register:
> + put_device(jpeg->larb);
>
> err_clk_init:
>
>
This is too confusing since it is not obvious that this is the
counterpart of mtk_jpeg_clk_init. I think it would be much easier
to understand if you add a mtk_jpeg_clk_release() which does this
put_device, and call that new function both here and in mtk_jpeg_remove().
Regards,
Hans
Powered by blists - more mailing lists