linux-kernel - Re: [PATCH -next] usb: Make sync_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd46nO9nXAZZ5-XKZR3_wq-o37MdmLNm_KUTSvhsq+whQ@mail.gmail.com>
Date:   Fri, 30 Oct 2020 13:18:33 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Al Cooper <alcooperx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        USB <linux-usb@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] usb: Make sync_all_pins static

On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@...wei.com> wrote:

The title can be more precise.

> Fix the following sparse warning:
>
> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?

Do we really need to know the path?

> The sync_all_pins has only call site within brcmstb-usb-pinmap.c

sync_all_pins()

> It should be static

Missed period.

-- 
With Best Regards,
Andy Shevchenko