linux-kernel - Re: [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201030112950.GA36162@kozik-lap>
Date:   Fri, 30 Oct 2020 12:29:50 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     "Yeh, Andy" <andy.yeh@...el.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tomasz Figa <tfiga@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG

On Wed, Oct 28, 2020 at 10:14:52AM +0000, Yeh, Andy wrote:
> >-----Original Message-----
> >From: Sakari Ailus <sakari.ailus@...ux.intel.com>
> >Sent: Wednesday, October 28, 2020 6:03 PM
> >To: Krzysztof Kozlowski <krzk@...nel.org>
> >Cc: Yeh, Andy <andy.yeh@...el.com>; Mauro Carvalho Chehab
> ><mchehab@...nel.org>; Tomasz Figa <tfiga@...omium.org>; Jason Chen
> ><jasonx.z.chen@...el.com>; Alan Chiang <alanx.chiang@...el.com>; linux-
> >media@...r.kernel.org; linux-kernel@...r.kernel.org;
> >stable@...r.kernel.org
> >Subject: Re: [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG
> >
> >On Wed, Oct 28, 2020 at 10:56:55AM +0100, Krzysztof Kozlowski wrote:
> >> On Wed, 28 Oct 2020 at 10:45, Krzysztof Kozlowski <krzk@...nel.org>
> >wrote:
> >> >
> >> > On Wed, 28 Oct 2020 at 10:43, Yeh, Andy <andy.yeh@...el.com> wrote:
> >> > >
> >> > > But the sensor settings for the original submission is to output GRBG
> >Bayer RAW.
> >> > >
> >> > > Regards, Andy
> >> >
> >> > No, not to my knowledge. There are no settings for color output
> >> > because it is fixed to GBGB/RGRG. I was looking a lot into this
> >> > driver (I have few other problems with it, already few other patches
> >> > posted) and I could not find a setting for this in datasheet. If you
> >> > know the setting for the other color - can you point me to it?
> >>
> >> And except the datasheet which mentions the specific format, the
> >> testing confirms it. With original color the pictures are pink/purple.
> >> With proper color, the pictures are correct (with more green color as
> >> expected for bayer).
> >
> >Quoting the driver's start_streaming function:
> >
> >        /* Set Orientation be 180 degree */
> >        ret = imx258_write_reg(imx258, REG_MIRROR_FLIP_CONTROL,
> >                               IMX258_REG_VALUE_08BIT, REG_CONFIG_MIRROR_FLIP);
> >        if (ret) {
> >                dev_err(&client->dev, "%s failed to set orientation\n",
> >                        __func__);
> >                return ret;
> >        }
> >
> >Could it be you're taking pictures of pink objects? ;-)
> >
> >--
> >Sakari Ailus
> 
> Sakari is right. IIRC since the default sensor settings outputs in GBRG, and after mirro/flip (it is the original application when submit the driver) the bayer order will be GRBG.

Yes, you are all right. It seems I was using wrong color mode for
Gstreamer, or I messed up something more.

Thanks for help everyone!

The patch can be dropped.

Best regards,
Krzysztof