linux-kernel - Re: [PATCH -next] mm, page_alloc: Fix old-style function definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79d7b9ee-6e0a-182c-bb44-d00382c2d5d0@redhat.com>
Date:   Fri, 30 Oct 2020 12:39:21 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Zou Wei <zou_wei@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mm, page_alloc: Fix old-style function definition

On 28.10.20 08:32, Zou Wei wrote:
> Fix warning:
> 
> mm/page_alloc.c:763:6: warning: old-style function definition [-Wold-style-definition]
>   void init_mem_debugging()
>        ^~~~~~~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>   mm/page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f80dc59..470b18d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -760,7 +760,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page,
>    * order of appearance. So we need to first gather the full picture of what was
>    * enabled, and then make decisions.
>    */
> -void init_mem_debugging()
> +void init_mem_debugging(void)
>   {
>   	if (_init_on_alloc_enabled_early) {
>   		if (page_poisoning_enabled()) {
> 

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb