linux-kernel - Re: [PATCH 1/1] usb: typec: add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201030132606.GD2333887@kuha.fi.intel.com>
Date:   Fri, 30 Oct 2020 15:26:06 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Amelie Delaunay <amelie.delaunay@...com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        Fabrice Gasnier <fabrice.gasnier@...com>
Subject: Re: [PATCH 1/1] usb: typec: add missing MODULE_DEVICE_TABLE() to
 stusb160x

On Wed, Oct 28, 2020 at 04:17:03PM +0100, Amelie Delaunay wrote:
> When stusb160x driver is built as a module, no modalias information is
> available, and it prevents the module to be loaded by udev.
> Add MODULE_DEVICE_TABLE() to fix this issue.
> 
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Signed-off-by: Amelie Delaunay <amelie.delaunay@...com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/stusb160x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index da7f1957bcb3..42076697e26c 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -633,6 +633,7 @@ static const struct of_device_id stusb160x_of_match[] = {
>  	{ .compatible = "st,stusb1600", .data = &stusb1600_regmap_config},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, stusb160x_of_match);
>  
>  static int stusb160x_probe(struct i2c_client *client)
>  {
> -- 
> 2.17.1

-- 
heikki