linux-kernel - Re: [PATCH] spi: sprd: add runtime pm for transfer message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030134227.GC4405@sirena.org.uk>
Date:   Fri, 30 Oct 2020 13:42:27 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Chunyan Zhang <zhang.lyra@...il.com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        Bangzheng Liu <bangzheng.liu@...soc.com>
Subject: Re: [PATCH] spi: sprd: add runtime pm for transfer message

On Fri, Oct 30, 2020 at 03:24:44PM +0800, Chunyan Zhang wrote:
> From: Bangzheng Liu <bangzheng.liu@...soc.com>
> 
> Before transfer one message, spi core would set chipselect, sprd spi
> device should be resumed from runtime suspend, otherwise kernel would
> crash once access spi registers. The sprd spi device can be suspended
> until clearing chipselect which would be executed after transfer.

The core should be handling runtime PM for normal transfers, if it's not
managing to do that then we should fix the core so it's fixed for all
drivers not just this one.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)