linux-kernel - Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030140420.GB666074@cmpxchg.org>
Date:   Fri, 30 Oct 2020 10:04:20 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     akpm@...ux-foundation.org, mgorman@...hsingularity.net,
        tj@...nel.org, hughd@...gle.com, khlebnikov@...dex-team.ru,
        daniel.m.jordan@...cle.com, willy@...radead.org, lkp@...el.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        cgroups@...r.kernel.org, shakeelb@...gle.com,
        iamjoonsoo.kim@....com, richard.weiyang@...il.com,
        kirill@...temov.name, alexander.duyck@...il.com,
        rong.a.chen@...el.com, mhocko@...e.com, vdavydov.dev@...il.com,
        shy828301@...il.com, Michal Hocko <mhocko@...nel.org>
Subject: Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if
 memcg disabled

On Fri, Oct 30, 2020 at 10:27:51AM +0800, Alex Shi wrote:
> 
> 
> 在 2020/10/29 下午9:46, Johannes Weiner 写道:
> >>  ? release_pages+0x1ae/0x410
> >>  shmem_alloc_and_acct_page+0x77/0x1c0
> >>  shmem_getpage_gfp+0x162/0x910
> >>  shmem_fault+0x74/0x210
> >>  ? filemap_map_pages+0x29c/0x410
> >>  __do_fault+0x37/0x190
> >>  handle_mm_fault+0x120a/0x1770
> >>  exc_page_fault+0x251/0x450
> >>  ? asm_exc_page_fault+0x8/0x30
> >>  asm_exc_page_fault+0x1e/0x30
> >>
> >> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> >> Reviewed-by: Roman Gushchin <guro@...com>
> >> Acked-by: Michal Hocko <mhocko@...e.com>
> >> Acked-by: Hugh Dickins <hughd@...gle.com>
> >> Cc: Johannes Weiner <hannes@...xchg.org>
> >> Cc: Michal Hocko <mhocko@...nel.org>
> >> Cc: Vladimir Davydov <vdavydov.dev@...il.com>
> >> Cc: Andrew Morton <akpm@...ux-foundation.org>
> >> Cc: cgroups@...r.kernel.org
> >> Cc: linux-mm@...ck.org
> >> Cc: linux-kernel@...r.kernel.org
> > Acked-by: Johannes Weiner <hannes@...xchg.org>
> > 
> > This should go in before the previous patch that adds the WARN for it.
> 
> Right, but than the long ops may not weird. Should I remove the ops and resend the whole patchset?

You mean the warning in the changelog? I think that's alright. You can
just say that you're about to remove the !page->memcg check in the
next patch because the original reasons for having it are gone, and
memcg being disabled is the only remaining exception, so this patch
makes that check explicit in preparation for the next.

Sorry, it's all a bit of a hassle, I just wouldn't want to introduce a
known warning into the kernel between those two patches (could confuse
bisection runs, complicates partial reverts etc.)