linux-kernel - Re: [PATCH v2 1/2] reboot: fix overflow parsing reboot cpu number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030141324.GD1602@alley>
Date:   Fri, 30 Oct 2020 15:13:24 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Matteo Croce <mcroce@...ux.microsoft.com>,
        linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        Arnd Bergmann <arnd@...db.de>, Mike Rapoport <rppt@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Robin Holt <robinmholt@...il.com>,
        Fabian Frederick <fabf@...net.be>, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] reboot: fix overflow parsing reboot cpu number

On Tue 2020-10-27 14:42:43, Greg KH wrote:
> On Tue, Oct 27, 2020 at 02:35:44PM +0100, Matteo Croce wrote:
> > From: Matteo Croce <mcroce@...rosoft.com>
> > 
> > Limit the CPU number to num_possible_cpus(), because setting it
> > to a value lower than INT_MAX but higher than NR_CPUS produces the
> > following error on reboot and shutdown:
> > 
> > Fixes: 1b3a5d02ee07 ("reboot: move arch/x86 reboot= handling to generic kernel")
> > Signed-off-by: Matteo Croce <mcroce@...rosoft.com>

Reviewed-by: Petr Mladek <pmladek@...e.com>

> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>

The best way is to add the following line before Signed-off-by line:

Cc: stable@...r.kernel.org

Best Regards,
Petr