linux-kernel - Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201030152450.77mtzkxjove36qfd@pali>
Date:   Fri, 30 Oct 2020 16:24:50 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, dsterba@...e.cz, aaptel@...e.com,
        willy@...radead.org, rdunlap@...radead.org, joe@...ches.com,
        mark@...mstone.com, nborisov@...e.com,
        linux-ntfs-dev@...ts.sourceforge.net, anton@...era.com
Subject: Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by
 Paragon Software

Hello and thanks for update!

I have just two comments for the last v11 version.

I really do not like nls_alt mount option and I do not think we should
merge this mount option into ntfs kernel driver. Details I described in:
https://lore.kernel.org/linux-fsdevel/20201009154734.andv4es3azkkskm5@pali/

tl;dr it is not systematic solution and is incompatible with existing
in-kernel ntfs driver, also incompatible with in-kernel vfat, udf and
ext4 (with UNICODE support) drivers. In my opinion, all kernel fs
drivers which deals with UNICODE should handle it in similar way.

It would be really bad if userspace application need to behave
differently for this new ntfs driver and differently for all other
UNICODE drivers.

Second comment is simplification of usage nls_load() with UTF-8 parameter
which I described in older email:
https://lore.kernel.org/linux-fsdevel/948ac894450d494ea15496c2e5b8c906@paragon-software.com/

You wrote that you have applied it, but seems it was lost (maybe during
rebase?) as it is not present in the last v11 version.

I suggested to not use nls_load() with UTF-8 at all. Your version of
ntfs driver does not use kernel's nls utf8 module for UTF-8 support, so
trying to load it should be avoided. Also kernel can be compiled without
utf8 nls module (which is moreover broken) and with my above suggestion,
ntfs driver would work correctly. Without that suggestion, mounting
would fail.