linux-kernel - Re: [PATCH] pwm: tiehrpwm: handle deferred probe with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Oct 2020 14:39:19 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Grygorii Strashko <grygorii.strashko@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Lee Jones <lee.jones@...aro.org>, <linux-pwm@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: tiehrpwm: handle deferred probe with dev_err_probe()



On 10/31/20 1:42 AM, Grygorii Strashko wrote:
> The devm_clk_get() may return -EPROBE_DEFER which is not handled properly
> by TI EHRPWM driver and causes unnecessary boot log messages.
> 
> Hence, add proper deferred probe handling with new dev_err_probe() API.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---

Reviewed-by: Vignesh Raghavendra <vigneshr@...com>

>  drivers/pwm/pwm-tiehrpwm.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index 0846917ff2d2..14c8fdcfd607 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -437,10 +437,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	if (IS_ERR(clk)) {
> -		dev_err(&pdev->dev, "failed to get clock\n");
> -		return PTR_ERR(clk);
> -	}
> +	if (IS_ERR(clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(clk), "Failed to get fck\n");
>  
>  	pc->clk_rate = clk_get_rate(clk);
>  	if (!pc->clk_rate) {
> @@ -462,10 +460,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  
>  	/* Acquire tbclk for Time Base EHRPWM submodule */
>  	pc->tbclk = devm_clk_get(&pdev->dev, "tbclk");
> -	if (IS_ERR(pc->tbclk)) {
> -		dev_err(&pdev->dev, "Failed to get tbclk\n");
> -		return PTR_ERR(pc->tbclk);
> -	}
> +	if (IS_ERR(pc->tbclk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(pc->tbclk), "Failed to get tbclk\n");
>  
>  	ret = clk_prepare(pc->tbclk);
>  	if (ret < 0) {
>