lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20201031113457.373067458@linuxfoundation.org> Date: Sat, 31 Oct 2020 12:35:36 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Chris Wilson <chris@...is-wilson.co.uk>, CQ Tang <cq.tang@...el.com>, Daniel Vetter <daniel.vetter@...el.com>, Tvrtko Ursulin <tvrtko.ursulin@...el.com>, Rodrigo Vivi <rodrigo.vivi@...el.com> Subject: [PATCH 5.4 40/49] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex From: Chris Wilson <chris@...is-wilson.co.uk> commit 4fe9af8e881d946bf60790eeb37a7c4f96e28382 upstream. Since the debugfs may peek into the GEM contexts as the corresponding client/fd is being closed, we may try and follow a dangling pointer. However, the context closure itself is serialised with the ctx->mutex, so if we hold that mutex as we inspect the state coupled in the context, we know the pointers within the context are stable and will remain valid as we inspect their tables. Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk> Cc: CQ Tang <cq.tang@...el.com> Cc: Daniel Vetter <daniel.vetter@...el.com> Cc: stable@...r.kernel.org Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@...el.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200723172119.17649-3-chris@chris-wilson.co.uk (cherry picked from commit 102f5aa491f262c818e607fc4fee08a724a76c69) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@...el.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -328,6 +328,7 @@ static void print_context_stats(struct s } i915_gem_context_unlock_engines(ctx); + mutex_lock(&ctx->mutex); if (!IS_ERR_OR_NULL(ctx->file_priv)) { struct file_stats stats = { .vm = ctx->vm, }; struct drm_file *file = ctx->file_priv->file; @@ -466,6 +467,7 @@ static int i915_interrupt_info(struct se intel_display_power_put(dev_priv, power_domain, pref); } + mutex_unlock(&ctx->mutex); pref = intel_display_power_get(dev_priv, POWER_DOMAIN_INIT); seq_printf(m, "Port hotplug:\t%08x\n",
Powered by blists - more mailing lists