lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c20d7c85-b2f3-608a-833f-093363fac5f5@redhat.com> Date: Sat, 31 Oct 2020 15:06:59 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Peter Xu <peterx@...hat.com>, linux-kernel@...r.kernel.org, kvm@...r.kernel.org, Takashi Iwai <tiwai@...e.de> Cc: Vitaly Kuznetsov <vkuznets@...hat.com>, Sean Christopherson <sean.j.christopherson@...el.com>, Steffen Dirkwinkel <kernel-bugs@...ffen.cc> Subject: Re: [PATCH 2/2] KVM: X86: Fix null pointer reference for KVM_GET_MSRS On 25/10/20 19:53, Peter Xu wrote: > kvm_msr_ignored_check() could trigger a null pointer reference if ignore_msrs=Y > and report_ignore_msrs=Y when try to fetch an invalid feature msr using the > global KVM_GET_MSRS. Degrade the error report to not rely on vcpu since that > information (index, rip) is not as important as msr index/data after all. > > Fixes: 12bc2132b15e0a96 > Reported-by: Steffen Dirkwinkel <kernel-bugs@...ffen.cc> > Signed-off-by: Peter Xu <peterx@...hat.com> > --- > arch/x86/kvm/x86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index ce856e0ece84..5993fbd6d2c5 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -259,8 +259,8 @@ static int kvm_msr_ignored_check(struct kvm_vcpu *vcpu, u32 msr, > > if (ignore_msrs) { > if (report_ignored_msrs) > - vcpu_unimpl(vcpu, "ignored %s: 0x%x data 0x%llx\n", > - op, msr, data); > + kvm_pr_unimpl("ignored %s: 0x%x data 0x%llx\n", > + op, msr, data); > /* Mask the error */ > return 0; > } else { > I committed Takashi Iwai's very similar patch. Please resend 1/2 with reviewer comments addressed, thanks! Paolo
Powered by blists - more mailing lists