linux-kernel - Re: [PATCH -next v2] usb: Mark sync_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71fd1c46-a674-a3a8-666c-d4240a866470@gmail.com>
Date:   Fri, 30 Oct 2020 18:54:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Zou Wei <zou_wei@...wei.com>, alcooperx@...il.com,
        gregkh@...uxfoundation.org, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com
Cc:     linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword



On 10/30/2020 6:48 PM, Zou Wei wrote:
> Fix the following sparse warning:
> 
> ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
> 
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
> Mark it static as suggested.
> 
> Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")

Not sure if the Fixes: tag is entirely appropriate here, but sure, why not.

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian