linux-kernel - Re: [PATCH v3 6/9] perf c2c: Support AUX trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201031202103.GA3380099@krava>
Date:   Sat, 31 Oct 2020 21:21:03 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Kemeng Shi <shikemeng@...wei.com>,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        Ian Rogers <irogers@...gle.com>, Al Grant <Al.Grant@....com>,
        James Clark <james.clark@....com>,
        Wei Li <liwei391@...wei.com>,
        André Przywara <andre.przywara@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 6/9] perf c2c: Support AUX trace

On Wed, Oct 28, 2020 at 02:38:10PM +0800, Leo Yan wrote:
> This patches adds the AUX callbacks in session structure, so support
> AUX trace for "perf c2c" tool.
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
>  tools/perf/builtin-c2c.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 4d1a08e38233..24f4af997aab 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -369,6 +369,10 @@ static struct perf_c2c c2c = {
>  		.exit		= perf_event__process_exit,
>  		.fork		= perf_event__process_fork,
>  		.lost		= perf_event__process_lost,
> +		.attr		= perf_event__process_attr,
> +		.auxtrace_info  = perf_event__process_auxtrace_info,
> +		.auxtrace       = perf_event__process_auxtrace,
> +		.auxtrace_error = perf_event__process_auxtrace_error,

so this will process aux data, but don't you have to
say which events you want to synthesize?

like in script/report via --itrace option?

aybe arm differs from x86 in this, and it's happening
in the background.. I have no idea ;-)

jirka

>  		.ordered_events	= true,
>  		.ordering_requires_timestamps = true,
>  	},
> -- 
> 2.17.1
>