Message-ID: <ba6d66ee-4470-afe9-da1d-790dc3b318fc@gmail.com>
Date:   Sun, 1 Nov 2020 02:38:34 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Aditya Srivastava <yashsri421@...il.com>
Subject: Re: [PATCH] checkpatch: improve handling of email comments


> Try this git log grep:
>
> $ git log --format=email -100000 | \
>    grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
>    grep -v 'stable\@' | \
>    grep -P '\>.+'
>
> This finds any signature/cc line with content after an
> email address that end with a close angle bracket that
> doesn't go to the stable address.
>
> Think about what content after that close angle bracket
> should and shoud not be allowed.
>
> There are a few variants here:
>
> o comments (optional whitespace, followed by '#' or '[' or '(' or c89)
> o misuse of quote (around the whole name and address)
> o Odd commas after '>' likely from defective cut'n'paste use
>
> Then add this to the first grep to avoid the comments as above
>
> $ git log --format=email -100000 | \
>    grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
>    grep -v 'stable\@' | \
>    grep -P '\>.+' | \
>    grep -vP '\>\s*(?:\#|\(|/\*|\[)'
>
> Shouldn't all these be reported?
> Are they if your patch is applied?
>
> Then look at the addresses that do not have a close angle
> bracket and also have more content after the email address.
>
> $ git log --format=email -100000 | \
>    grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
>    grep -v 'stable@' | \
>    grep -vP '<[\w\.\@\+\-]+>' | \
>    grep -vP '[\w\.\@\+\-]+$'
>
> What of all of these should be reported?
>
> Happy testing...
>
Hi,
So I ran the tests and there are some interesting results.

The warnings were the same before and after this patch
was applied.

For illegal elements after the closing braces, there were
several errors for which no warnings were reported. These
are:

       6 Cc: Peter Zijlstra <peterz@...radead.org>,
       5 Reviewed-by: "Dietmar Eggemann <dietmar.eggemann@....com>"
       1 Suggested-by: Julia Lawall <julia.lawall@...6.fr>.
       1 Signed-off-by: Vishal Kulkarni <vishal@...lsio.com>"
       1 Signed-off-by: Vishal Kulkarni <vishal@...lsio.com>"
       1 Signed-off-by: Vishal Kulkarni <vishal@...lsio.com>"
       1 Signed-off-by: Veerabhadrarao Badiganti 
<vbadigan@...eaurora.org> Link:
       1 Signed-off-by: Jingle Wu <jingle.wu@....com.tw>.
       1 Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
       1 Reviewed-by: Max Gurtovoy <maxg@...lanox.com 
<mailto:maxg@...lanox.com>>
       1 Reviewed-by: Maulik Shah <mkshah@...eaurora.org> Thanks, Maulik
       1 Reviewed-by: Marc Zyngier <maz@...nel.org> Link: 
https://lore.kernel.org/r/20200826112331.047917603@linutronix.de
       1 Reviewed-by: David Sterba <dsterba@...e.com>i
       1 Reviewed-by: David Sterba <dsterba@...e.com>c
       1 Reviewed-by: David Sterba <dsterba@...e.com>3
       1 Reviewed-by: Christoph Hellwig <hch@....de>,
       1 Reviewed-by: Christian König <christian.koenig@....com> for both.
       1 Reviewed-by: Christian König <christian.koenig@....com>.
       1 Reported-by: Randy Dunlap <rdunlap@...radead.org>>
       1 Reported-by: Qian Cai <cai@...hat.com>>
       1 Reported-by: Qian Cai <cai@....pw> writes:
       1 Reported-by: kernel test robot <lkp@...el.com> for missing #include
       1 Reported-by: "kernelci.org bot" <bot@...nelci.org>"
       1 Reported-by: kbuild test robot <lkp@...el.com>]
       1 Reported-by: Bob Sanders <bob.sanders@....com> and the LTP 
testsuite
       1 Cc: Wolfram Sang <wsa@...nel.org>,
       1 Cc: Valdis Kletnieks <valdis.kletnieks@...edu>,
       1 Cc: Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
       1 CC: Stephen Rothwell <sfr@...b.auug.org.au>,
       1 Cc: Sia, Jee Heng <jee.heng.sia@...el.com>; 
alsa-devel@...a-project.org; linux-kernel@...r.kernel.org; 
clang-built-linux@...glegroups.com; Nathan Chancellor 
<natechancellor@...il.com>
       1 Cc: Robert Sesek <rsesek@...gle.com>,
       1 CC: Peter Zijlstra <peterz@...radead.org>,
       1 Cc: Omar Sandoval <osandov@...com>,
       1 Cc: Michael Neuling <mikey@...ling.org> <mikey@...ling.org>
       1 Cc: Maxime Ripard <mripard@...nel.org>,
       1 Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
       1 Cc: Mark Scott <mscott@...cepoint.com>,
       1 Cc: Mark Rutland <mark.rutland@....com>.
       1 Cc: Mark Rutland <mark.rutland@....com>,
       1 Cc: Mark Rutland <mark.rutland@....com>,
       1 Cc: Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
       1 Cc: Kees Cook <keescook@...gle.com>,
       1 Cc: Jonas Karlman <jonas@...boo.se>,
       1 Cc: Jernej Skrabec <jernej.skrabec@...l.net>,
       1 Cc: Jason Wang <jasowang@...hat.com>; Parav Pandit 
<parav@...lanox.com>; virtualization@...ts.linux-foundation.org; 
linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
       1 Cc: Jann Horn <jannh@...gle.com>,
       1 Cc: James Bottomley <james.bottomley@...senpartnership.com>,
       1 Cc: Icenowy Zheng <icenowy@...c.io>,
       1 Cc: Dan Murphy <dmurphy@...com>A
       1 Cc: Daniel Vetter <daniel@...ll.ch>,
       1 Cc: Christoph Lameter <cl@...ux.com>Cc: Pekka Enberg 
<penberg@...nel.org>
       1 Cc: Christoph Hellwig <hch@....de>,
       1 Cc: Christian König <christian.koenig@....com>.
       1 CC: "Chang S. Bae" <chang.seok.bae@...el.com>,
       1 Cc: Al Viro <viro@...iv.linux.org.uk>e
       1 Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>A
       1 Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>A


For cases with no closing '>', following cases were not
reported by checkpatch:

       6 Cc: linux-arm-kernel@...ts.infradead.org,
       1 Reviewed-by: Max Gurtovoy <maxg@...lanox.com 
<mailto:maxg@...lanox.com>>
       1 Cc: rostedt@...dmis.org,
       1 Cc: linux-wireless@...r.kernel.org,
       1 Cc: dri-devel@...ts.freedesktop.org,

So it's mostly extra commas at the end. But other
illegal characters were also there. Also in one or two
cases, multiple addresses were stacked together.
I think these all deserve to be reported.

Thanks,
Dwaipayan.

Powered by blists - more mailing lists