linux-kernel - Re: [PATCH 0/3] Fix kernfs node reference count leak issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2708b32-e7f5-dae9-63d5-a35c97f25ea7@intel.com>
Date:   Sat, 31 Oct 2020 13:35:28 +0800
From:   Xiaochen Shen <xiaochen.shen@...el.com>
To:     Reinette Chatre <reinette.chatre@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "willemb@...gle.com" <willemb@...gle.com>
Cc:     "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jia, Pei P" <pei.p.jia@...el.com>,
        Xiaochen Shen <xiaochen.shen@...el.com>
Subject: Re: [PATCH 0/3] Fix kernfs node reference count leak issues

Hi Reinette,

Thank you for correcting this!

The subject of this "cover letter" should be:
x86/resctrl: Fix kernfs node reference count leak issues

On 10/31/2020 5:18, Reinette Chatre wrote:
> Apologies, the Subject intended to have a "x86/resctrl:" prefix.
>
> On 10/30/2020 12:02 PM, Xiaochen Shen wrote:
>> Fix several kernfs node reference count leak issues:
>> (1) Remove superfluous kernfs_get() calls to prevent refcount leak
>> (2) Add necessary kernfs_put() calls to prevent refcount leak
>> (3) Follow-up cleanup for the change in previous patch.
>>
>> Xiaochen Shen (3):
>>     x86/resctrl: Remove superfluous kernfs_get() calls to prevent refcount
>>       leak
>>     x86/resctrl: Add necessary kernfs_put() calls to prevent refcount leak
>>     x86/resctrl: Clean up unused function parameter in rmdir path
>>
>>    arch/x86/kernel/cpu/resctrl/rdtgroup.c | 82 ++++++++++++++--------------------
>>    1 file changed, 33 insertions(+), 49 deletions(-)
>>

-- 
Best regards,
Xiaochen