linux-kernel - Re: [PATCH v4] iio: light: vcnl4035 add i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Nov 2020 15:26:13 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Vaishnav M A <vaishnav@...gleboard.org>
Cc:     andy.shevchenko@...il.com, wsa@...nel.org, knaack.h@....de,
        lars@...afoo.de, alexandru.ardelean@...log.com,
        matt.ranostay@...sulko.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] iio: light: vcnl4035 add i2c_device_id

On Mon, 19 Oct 2020 01:23:57 +0530
Vaishnav M A <vaishnav@...gleboard.org> wrote:

> Add i2c_device_id table for the vcnl4035 driver,
> enabling device instantiation using i2c_new_client_device()
> or from userspace in cases where device-tree based description
> is not possible now, like device(s) on a gbphy i2c adapter
> created by greybus.
> 
> Signed-off-by: Vaishnav M A <vaishnav@...gleboard.org>
Applied,

Thanks,

Jonathan

> ---
>  v4:
> 	-update commit message, add punctuation.
>  v3:
> 	-modify commit message for readability
> 	 as suggested by Jonathan Cameron
>  v2:
> 	-fix commit message
>  drivers/iio/light/vcnl4035.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 765c44adac57..73a28e30dddc 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
>  			   vcnl4035_runtime_resume, NULL)
>  };
>  
> +static const struct i2c_device_id vcnl4035_id[] = {
> +	{ "vcnl4035", 0},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> +
>  static const struct of_device_id vcnl4035_of_match[] = {
>  	{ .compatible = "vishay,vcnl4035", },
>  	{ }
> @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
>  	},
>  	.probe  = vcnl4035_probe,
>  	.remove	= vcnl4035_remove,
> +	.id_table = vcnl4035_id,
>  };
>  
>  module_i2c_driver(vcnl4035_driver);