linux-kernel - Re: [PATCH] perf tools: Add missing swap for cgroup events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201102174956.GA3597846@krava>
Date:   Mon, 2 Nov 2020 18:49:56 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH] perf tools: Add missing swap for cgroup events

On Mon, Nov 02, 2020 at 11:02:28PM +0900, Namhyung Kim wrote:
> It was missed to add a swap function for PERF_RECORD_CGROUP.
> 
> Fixes: ba78c1c5461c ("perf tools: Basic support for CGROUP event")

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/session.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 7a5f03764702..c44c8e8c09c6 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -710,6 +710,18 @@ static void perf_event__namespaces_swap(union perf_event *event,
>  		swap_sample_id_all(event, &event->namespaces.link_info[i]);
>  }
>  
> +static void perf_event__cgroup_swap(union perf_event *event, bool sample_id_all)
> +{
> +	event->cgroup.id = bswap_64(event->cgroup.id);
> +
> +	if (sample_id_all) {
> +		void *data = &event->cgroup.path;
> +
> +		data += PERF_ALIGN(strlen(data) + 1, sizeof(u64));
> +		swap_sample_id_all(event, data);
> +	}
> +}
> +
>  static u8 revbyte(u8 b)
>  {
>  	int rev = (b >> 4) | ((b & 0xf) << 4);
> @@ -952,6 +964,7 @@ static perf_event__swap_op perf_event__swap_ops[] = {
>  	[PERF_RECORD_SWITCH]		  = perf_event__switch_swap,
>  	[PERF_RECORD_SWITCH_CPU_WIDE]	  = perf_event__switch_swap,
>  	[PERF_RECORD_NAMESPACES]	  = perf_event__namespaces_swap,
> +	[PERF_RECORD_CGROUP]		  = perf_event__cgroup_swap,
>  	[PERF_RECORD_TEXT_POKE]		  = perf_event__text_poke_swap,
>  	[PERF_RECORD_HEADER_ATTR]	  = perf_event__hdr_attr_swap,
>  	[PERF_RECORD_HEADER_EVENT_TYPE]	  = perf_event__event_type_swap,
> -- 
> 2.29.1.341.ge80a0c044ae-goog
>