linux-kernel - Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit mask from KEX profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201102095342.38c5d5c1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 2 Nov 2020 09:53:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Naveen Mamindlapalli <naveenm@...vell.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <sgoutham@...vell.com>,
        <lcherian@...vell.com>, <gakula@...vell.com>, <jerinj@...vell.com>,
        <sbhatta@...vell.com>, <hkelam@...vell.com>
Subject: Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit
 mask from KEX profile

On Mon, 2 Nov 2020 11:41:12 +0530 Naveen Mamindlapalli wrote:
> From: Subbaraya Sundeep <sbhatta@...vell.com>
> 
> Key Extraction(KEX) profile decides how the packet metadata such as
> layer information and selected packet data bytes at each layer are
> placed in MCAM search key. This patch reads the configured KEX profile
> parameters to find out the bit position and bit mask for each field.
> The information is used when programming the MCAM match data by SW
> to match a packet flow and take appropriate action on the flow. This
> patch also verifies the mandatory fields such as channel and DMAC
> are not overwritten by the KEX configuration of other fields.
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@...vell.com>

Lots of new warnings like this here:

drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:351:38: warning: implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum-conversion]
  351 |  if (npc_check_overlap(rvu, blkaddr, NPC_ETYPE, start_lid, intf))
      |                                      ^~~~~~~~~