linux-kernel - Re: [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201102190335.GA25451@duo.ucw.cz>
Date:   Mon, 2 Nov 2020 20:03:35 +0100
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     Luka Kovacic <luka.kovacic@...tura.hr>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-hwmon@...r.kernel.org,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Marek Behun <marek.behun@....cz>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Robert Marko <robert.marko@...tura.hr>
Subject: Re: [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU

On Mon 2020-11-02 12:29:59, Dan Murphy wrote:
> Hello
> 
> On 11/1/20 3:56 AM, Luka Kovacic wrote:
> > Hello Pavel,
> > 
> > On Thu, Oct 29, 2020 at 7:01 PM Pavel Machek <pavel@....cz> wrote:
> > > Hi!
> > > 
> > > > +What:                /sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/power_status
> > > > +Date:                September 2020
> > > > +Contact:     Luka Kovacic <luka.kovacic@...tura.hr>
> > > > +Description: (RO) Power status indicates the host platform power on method.
> > > > +             Value mapping (bitwise list):
> > > > +             0x80 - Null
> > > > +             0x40 - Firmware flag
> > > > +             0x20 - Power loss detection flag (powered off)
> > > > +             0x10 - Power loss detection flag (AC mode)
> > > > +             0x08 - Button power on
> > > > +             0x04 - WOL power on
> > > > +             0x02 - RTC alarm power on
> > > > +             0x01 - AC recover power on
> > > It would be nice to put this into standard place somewhere. Many
> > > machines will want to expose this information.
> > As this is specific to this microcontroller and to how it encodes
> > these values, I don't see a need to change this.
> > This isn't used anywhere else.
> > 
> > > If not, at least spell out WoL, as it is not that common of acronym.
> > Okay.
> 
> WoL is a very common acronym especially in the networking space

WoL is common. WOL is not. Better spell it out.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)