linux-kernel - Re: [PATCH -next] drm/amd/pm: remove unused variable

Open Source and information security mailing list archives

Message-ID: <CADnq5_OLB62R9NA_n6JW5vJQPANmBXD6DapMvP74i=amevxE1Q@mail.gmail.com>
Date:   Mon, 2 Nov 2020 14:04:29 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Xiaojian Du <Xiaojian.Du@....com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amd/pm: remove unused variable

On Mon, Nov 2, 2020 at 8:44 AM Zou Wei <zou_wei@...wei.com> wrote:
>
> Fix variable set but not used compilation warning:
>
> ./vangogh_ppt.c:397:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>   int ret = 0;
>       ^~~
>

Maybe you have an older version of the code?  It's currently used.

Alex

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 6e26025..355ade5 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -394,8 +394,6 @@ static int vangogh_get_current_activity_percent(struct smu_context *smu,
>                                                enum amd_pp_sensors sensor,
>                                                uint32_t *value)
>  {
> -       int ret = 0;
> -
>         if (!value)
>                 return -EINVAL;
>
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives