lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 2 Nov 2020 12:21:57 +0530
From:   kajoljain <kjain@...ux.ibm.com>
To:     trix@...hat.com, maximlevitsky@...il.com, oakad@...oo.com,
        ulf.hansson@...aro.org
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memstick: mspro_block: remove unneeded semicolon



On 10/31/20 7:18 PM, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> A semicolon is not needed after a switch statement.

Hi Tom,
   I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
any logical issue do we still need to add fix tag?

Thanks,
Kajol Jain
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/memstick/core/mspro_block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index cd6b8d4f2335..afb892e7ffc6 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
>  		return "attr_devinfo";
>  	default:
>  		return NULL;
> -	};
> +	}
>  }
>  
>  typedef ssize_t (*sysfs_show_t)(struct device *dev,
> 

Powered by blists - more mailing lists