linux-kernel - Re: [PATCH v2] ubifs: Fix the printing type of c->big

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c5dc46a06f784380a7c3f8186059fc1a@huawei.com>
Date:   Mon, 2 Nov 2020 07:46:18 +0000
From:   kechengsong <kechengsong@...wei.com>
To:     Richard Weinberger <richard.weinberger@...il.com>
CC:     Richard Weinberger <richard@....at>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "wangfangpeng (A)" <wangfangpeng1@...wei.com>
Subject: Re: [PATCH v2] ubifs: Fix the printing type of c->big_lpt

On Sat, Oct 31, 2020 at 9:56 AM Chengsong Ke <kechengsong@...wei.com> wrote:
>
> Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable of 
> type unsigned int and should be printed with %u.
>
> Well, it is:
> unsigned int big_lpt:1;
> So, either 0 or 1.
> 
> Does changing it to %u silence some static checker or is there some other problem I don't see right now? :-)
> 
> Thanks,
> //Richard

This is just a coding style issue, I found in the ubifs code. :-)
Thanks,
//Chengsong Ke