linux-kernel - Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Nov 2020 09:20:21 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     赵仪峰 <yifeng.zhao@...k-chips.com>
Cc:     "Johan Jonker" <jbx6244@...il.com>, richard <richard@....at>,
        vigneshr <vigneshr@...com>, robh+dt <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        HeikoStübner <heiko@...ech.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-rockchip <linux-rockchip@...ts.infradead.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308,
 RK2928 and others

Hi Yifeng,

赵仪峰 <yifeng.zhao@...k-chips.com> wrote on Mon, 2 Nov 2020 16:14:01
+0800:

> Hi Miquel,
> 
> The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1,
> but the nand controller do nothing and the cs of the NAND device is still selected, 
> so the NAND device  will not enter auto power save mode.

Yes, I need to think about it again.

What I am saying is that this has *nothing* to do with the controller
driver your are trying to merge. Please focus on the bare features.
Once these will be merged, it will be easier to propose changes on top
of it to bring more fine grained features.

It's v13 already, please focus on the controller's basic features,
implement them correctly and in a second time we'll think about the
power consumption, what do you think?

Thanks,
Miquèl