linux-kernel - Re: [PATCH] nvme: Simplify the nvme_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2735ac5c-3d7a-0829-368a-2066e75fe635@linux.alibaba.com>
Date:   Mon, 2 Nov 2020 19:44:21 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     kbusch@...nel.org, axboe@...com, hch@....de, sagi@...mberg.me
Cc:     baolin.wang7@...il.com, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: Simplify the nvme_req_qid()

Hi,

> Use the request's '->mq_hctx->queue_num' directly to simplify the
> nvme_req_qid() function.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

Gentle ping?

> ---
>   drivers/nvme/host/nvme.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index cc11113..0b62b62 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -178,7 +178,8 @@ static inline u16 nvme_req_qid(struct request *req)
>   {
>   	if (!req->q->queuedata)
>   		return 0;
> -	return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(req)) + 1;
> +
> +	return req->mq_hctx->queue_num + 1;
>   }
>   
>   /* The below value is the specific amount of delay needed before checking
>