linux-kernel - 答复: [PATCH -next] drm/panfrost: Fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Nov 2020 11:54:43 +0000
From:   "Zouwei (Samuel)" <zou_wei@...wei.com>
To:     Steven Price <steven.price@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "tomeu.vizoso@...labora.com" <tomeu.vizoso@...labora.com>,
        "alyssa.rosenzweig@...labora.com" <alyssa.rosenzweig@...labora.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH -next] drm/panfrost: Fix unused variable warning

Hi Steve,
Sorry, I didn't notice the patch earlier.
Please ignore my patch.

-----邮件原件-----
发件人: Steven Price [mailto:steven.price@....com] 
发送时间: 2020年11月2日 17:29
收件人: Zouwei (Samuel) <zou_wei@...wei.com>; robh@...nel.org; tomeu.vizoso@...labora.com; alyssa.rosenzweig@...labora.com; airlied@...ux.ie; daniel@...ll.ch
抄送: dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH -next] drm/panfrost: Fix unused variable warning

On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
> 
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
>    struct panfrost_job_slot *js = pfdev->js;
>                              ^~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Boris posted an identical patch earlier:

https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com

Steve

> ---
>   drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>   
>   void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
>   {
> -	struct panfrost_device *pfdev = panfrost_priv->pfdev;
> -	struct panfrost_job_slot *js = pfdev->js;
>   	int i;
>   
>   	for (i = 0; i < NUM_JOB_SLOTS; i++)
>