lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 2 Nov 2020 14:07:25 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Johan Jonker <jbx6244@...il.com>
Cc:     Yifeng <yifeng.zhao@...k-chips.com>, richard@....at,
        vigneshr@...com, robh+dt@...nel.org, devicetree@...r.kernel.org,
        heiko@...ech.de, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308,
 RK2928 and others

Hi Johan, Yifeng

Johan Jonker <jbx6244@...il.com> wrote on Mon, 2 Nov 2020 13:57:56
+0100:

> Hi Yifeng,
> 
> Don't poke with "ecc->bytes" ones it is set in rk_nfc_ecc_init(). It
> will not be noted by the MTD frame work or userspace. I think there's
> currently no way to let the user know that a different ECC must be used.
> Neither can the user set ECC on the fly.
> 
> Example R/W flow:
> 
>         nand_select_target()
> 	chip->ecc.write_page_raw()
> 	chip->ecc.write_page()
> 
> [..]
> 
> 	chip->ecc.read_page_raw()
> 	chip->ecc.read_page()
>         nand_deselect_target()
> 
> A write/read with:
> 
> rk_nfc_read_page_hwecc()
> rk_nfc_write_page_hwecc()
> 
> or
> 
> rk_nfc_read_page_raw()
> rk_nfc_write_page_raw()
> 
> must end up with the same result. If we can't archive that, then we
> shouldn't offer RAW mode to the user for now. If Miquel agrees you
> should just get the driver ready now without these 2 functions and round
> things up.

What about just not supporting the BootROM area if it was marked
"reserved" by the BRom in the DT?

Raw accessors is really a nice and basic feature that I would like to
have in every new driver.

Thanks,
Miquèl

Powered by blists - more mailing lists