linux-kernel - Re: [PATCH] lib: add basic KUnit test for lib/math

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201102145111.GD20030@xsang-OptiPlex-9020>
Date:   Mon, 2 Nov 2020 22:51:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Latypov <dlatypov@...gle.com>,
        andriy.shevchenko@...ux.intel.com
Cc:     kbuild-all@...ts.01.org, brendanhiggins@...gle.com,
        davidgow@...gle.com, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org,
        Daniel Latypov <dlatypov@...gle.com>
Subject: Re: [PATCH] lib: add basic KUnit test for lib/math

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 7cf726a59435301046250c42131554d9ccc566b8]

url:    https://github.com/0day-ci/linux/commits/Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737
base:    7cf726a59435301046250c42131554d9ccc566b8
:::::: branch date: 13 days ago
:::::: commit date: 13 days ago
config: i386-randconfig-s002-20201101 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-68-g49c98aa3-dirty
        # https://github.com/0day-ci/linux/commit/e268c8ae297dc311e5deb6b25daad9a2f88309ba
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737
        git checkout e268c8ae297dc311e5deb6b25daad9a2f88309ba
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


"sparse warnings: (new ones prefixed by >>)"
>> lib/math/math_test.c:137:37: sparse: sparse: shift too big (32) for type unsigned long

vim +137 lib/math/math_test.c

e268c8ae297dc31 Daniel Latypov 2020-10-19  109  
e268c8ae297dc31 Daniel Latypov 2020-10-19  110  static void int_sqrt_test(struct kunit *test)
e268c8ae297dc31 Daniel Latypov 2020-10-19  111  {
e268c8ae297dc31 Daniel Latypov 2020-10-19  112  	const char *message_fmt = "sqrt(%lu)";
e268c8ae297dc31 Daniel Latypov 2020-10-19  113  	int i;
e268c8ae297dc31 Daniel Latypov 2020-10-19  114  
e268c8ae297dc31 Daniel Latypov 2020-10-19  115  	struct test_case test_cases[] = {
e268c8ae297dc31 Daniel Latypov 2020-10-19  116  		{
e268c8ae297dc31 Daniel Latypov 2020-10-19  117  			.a = 0,
e268c8ae297dc31 Daniel Latypov 2020-10-19  118  			.result = 0,
e268c8ae297dc31 Daniel Latypov 2020-10-19  119  		},
e268c8ae297dc31 Daniel Latypov 2020-10-19  120  		{
e268c8ae297dc31 Daniel Latypov 2020-10-19  121  			.a = 1,
e268c8ae297dc31 Daniel Latypov 2020-10-19  122  			.result = 1,
e268c8ae297dc31 Daniel Latypov 2020-10-19  123  		},
e268c8ae297dc31 Daniel Latypov 2020-10-19  124  		{
e268c8ae297dc31 Daniel Latypov 2020-10-19  125  			.a = 4,
e268c8ae297dc31 Daniel Latypov 2020-10-19  126  			.result = 2,
e268c8ae297dc31 Daniel Latypov 2020-10-19  127  		},
e268c8ae297dc31 Daniel Latypov 2020-10-19  128  		{
e268c8ae297dc31 Daniel Latypov 2020-10-19  129  			.a = 5,
e268c8ae297dc31 Daniel Latypov 2020-10-19  130  			.result = 2,
e268c8ae297dc31 Daniel Latypov 2020-10-19  131  		},
e268c8ae297dc31 Daniel Latypov 2020-10-19  132  		{
e268c8ae297dc31 Daniel Latypov 2020-10-19  133  			.a = 8,
e268c8ae297dc31 Daniel Latypov 2020-10-19  134  			.result = 2,
e268c8ae297dc31 Daniel Latypov 2020-10-19  135  		},
e268c8ae297dc31 Daniel Latypov 2020-10-19  136  		{
e268c8ae297dc31 Daniel Latypov 2020-10-19 @137  			.a = 1UL >> 32,
e268c8ae297dc31 Daniel Latypov 2020-10-19  138  			.result = 1UL >> 16,
e268c8ae297dc31 Daniel Latypov 2020-10-19  139  		},
e268c8ae297dc31 Daniel Latypov 2020-10-19  140  	};
e268c8ae297dc31 Daniel Latypov 2020-10-19  141  
e268c8ae297dc31 Daniel Latypov 2020-10-19  142  	for (i = 0; i < ARRAY_SIZE(test_cases); ++i) {
e268c8ae297dc31 Daniel Latypov 2020-10-19  143  		KUNIT_EXPECT_EQ_MSG(test, int_sqrt(test_cases[i].a),
e268c8ae297dc31 Daniel Latypov 2020-10-19  144  				    test_cases[i].result, message_fmt,
e268c8ae297dc31 Daniel Latypov 2020-10-19  145  				    test_cases[i].a);
e268c8ae297dc31 Daniel Latypov 2020-10-19  146  	}
e268c8ae297dc31 Daniel Latypov 2020-10-19  147  }
e268c8ae297dc31 Daniel Latypov 2020-10-19  148  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34557 bytes)