linux-kernel - Re: [RESEND] venus: fix calculating mbps in calculate_inst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf8acb0c470207289a09f63d829dfb08@codeaurora.org>
Date:   Mon, 02 Nov 2020 21:09:15 +0530
From:   vgarodia@...eaurora.org
To:     Mansur Alisha Shaik <mansur@...eaurora.org>
Cc:     linux-media@...r.kernel.org, stanimir.varbanov@...aro.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [RESEND] venus: fix calculating mbps in calculate_inst_freq()

Hi Mansur,

On 2020-11-02 16:01, Mansur Alisha Shaik wrote:
> Currently in calculate_inst_freq(), video driver is calculating
> macro blocks per frame in stead of macro blocks per second(mpbs).
instead

> Which results frequency is always setting to lower frequency (150MB)
> as per frequency table for sc7180. Hence the playback is not smooth.
150MHz

> 
> Corrected this by correcting the mbps calculation in 
> calculate_inst_freq().
> 
> Signed-off-by: Mansur Alisha Shaik <mansur@...eaurora.org>
> ---
>  drivers/media/platform/qcom/venus/pm_helpers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
> b/drivers/media/platform/qcom/venus/pm_helpers.c
> index 57877ea..001513f 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -928,7 +928,7 @@ static unsigned long calculate_inst_freq(struct
> venus_inst *inst,
>  	u32 fps = (u32)inst->fps;
>  	u32 mbs_per_sec;
> 
> -	mbs_per_sec = load_per_instance(inst) / fps;
> +	mbs_per_sec = load_per_instance(inst);

Good find.

Thanks,
Vikash