linux-kernel - Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Nov 2020 18:00:13 +0100
From:   Paul Kocialkowski <contact@...lk.fr>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Matteo Scordino <matteo.scordino@...il.com>,
        Icenowy Zheng <icenowy@...c.io>
Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179
 bindings

On Mon 02 Nov 20, 15:27, Maxime Ripard wrote:
> On Mon, Nov 02, 2020 at 11:33:40AM +0100, Paul Kocialkowski wrote:
> > Hi,
> > 
> > On Mon 02 Nov 20, 11:13, Maxime Ripard wrote:
> > > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote:
> > > > Document the compatible strings for the SL631 Action Camera with IMX179.
> > > > 
> > > > Signed-off-by: Paul Kocialkowski <contact@...lk.fr>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > index afa00268c7db..0fa0c0b5d89f 100644
> > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > @@ -754,6 +754,12 @@ properties:
> > > >            - const: sinlinx,sina33
> > > >            - const: allwinner,sun8i-a33
> > > >  
> > > > +      - description: SL631 Action Camera with IMX179
> > > > +        items:
> > > > +          - const: unknown,sl631-imx179
> > > > +          - const: unknown,sl631
> > > > +          - const: allwinner,sun8i-v3
> > > > +
> > > 
> > > unknown is not a valid vendor (and you should explain why you picked
> > > that vendor name in the first place).
> > 
> > Ah right, it's not in the vendor prefixes. The rationale is that there is no
> > indication of what the vendor might be on the PCB. Should I maybe use
> > allwinner here?
> 
> You should mention it in the commit log for a start :)

Definitely.

> But yeah, we've used allwinner as a fallback for those cases so far.

Okay then, I'll go with that and add some explanation in the commit log.

Thanks for the review!

Cheers,

Paul

-- 
Developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)