| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Nov 2020 10:43:58 -0600
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Vinod Koul <vkoul@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SDX55 pinctrl
bindings
On Mon 02 Nov 23:58 CST 2020, Vinod Koul wrote:
> Add device tree binding Documentation details for Qualcomm SDX55
> pinctrl driver.
>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
> .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 145 ++++++++++++++++++
> 1 file changed, 145 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
> new file mode 100644
> index 000000000000..95b77d9a608c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
> @@ -0,0 +1,145 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/qcom,sdx55-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. SDX55 TLMM block
> +
> +maintainers:
> + - Vinod Koul <vkoul@...nel.org>
> +
> +description: |
> + This binding describes the Top Level Mode Multiplexer block found in the
> + SDX55 platform.
> +
> +properties:
> + compatible:
> + const: qcom,sdx55-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: Specifies the TLMM summary IRQ
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + description:
> + Specifies the PIN numbers and Flags, as defined in defined in
> + include/dt-bindings/interrupt-controller/irq.h
> + const: 2
> +
> + gpio-controller: true
> +
> + '#gpio-cells':
> + description: Specifying the pin number and flags, as defined in
> + include/dt-bindings/gpio/gpio.h
> + const: 2
> +
> + gpio-ranges:
> + maxItems: 1
> +
> + wakeup-parent:
> + maxItems: 1
> +
> +#PIN CONFIGURATION NODES
> +patternProperties:
> + '-pins$':
> + type: object
> + description:
> + Pinctrl node's client devices use subnodes for desired pin configuration.
> + Client device subnodes use below standard properties.
> + $ref: "/schemas/pinctrl/pincfg-node.yaml"
> +
> + properties:
> + pins:
> + description:
> + List of gpio pins affected by the properties specified in this subnode.
> + items:
> + oneOf:
> + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-6])$"
> + - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data ]
> + minItems: 1
> + maxItems: 36
> +
> + function:
> + description:
> + Specify the alternative function to be configured for the specified
> + pins. Functions are only valid for gpio pins.
> + enum: [ adsp_ext, atest, audio_ref, bimc_dte0, bimc_dte1, blsp_i2c1,
> + blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_spi1, blsp_spi2,
> + blsp_spi3, blsp_spi4, blsp_uart1, blsp_uart2, blsp_uart3,
> + blsp_uart4, char_exec, coex_uart, coex_uart2, cri_trng,
> + cri_trng0, cri_trng1, dbg_out, ddr_bist, ddr_pxi0,
> + ebi0_wrcdc, ebi2_a, ebi2_lcd, emac_gcc0, emac_gcc1,
> + emac_pps0, emac_pps1, ext_dbg, gcc_gp1, gcc_gp2, gcc_gp3,
> + gcc_plltest, gpio, i2s_mclk, jitter_bist, ldo_en, ldo_update,
> + mgpi_clk, m_voc, native_char, native_char0, native_char1,
> + native_char2, native_char3, native_tsens, native_tsense,
> + nav_gpio, pa_indicator, pcie_clkreq, pci_e, pll_bist, pll_ref,
> + pll_test, pri_mi2s, prng_rosc, qdss_cti, qdss_gpio,
> + qdss_gpio0, qdss_gpio1, qdss_gpio2, qdss_gpio3, qdss_gpio4,
> + qdss_gpio5, qdss_gpio6, qdss_gpio7, qdss_gpio8, qdss_gpio9,
> + qdss_gpio10, qdss_gpio11, qdss_gpio12, qdss_gpio13,
> + qdss_gpio14, qdss_gpio15, qdss_stm0, qdss_stm1, qdss_stm2,
> + qdss_stm3, qdss_stm4, qdss_stm5, qdss_stm6, qdss_stm7,
> + qdss_stm8, qdss_stm9, qdss_stm10, qdss_stm11, qdss_stm12,
> + qdss_stm13, qdss_stm14, qdss_stm15, qdss_stm16, qdss_stm17,
> + qdss_stm18, qdss_stm19, qdss_stm20, qdss_stm21, qdss_stm22,
> + qdss_stm23, qdss_stm24, qdss_stm25, qdss_stm26, qdss_stm27,
> + qdss_stm28, qdss_stm29, qdss_stm30, qdss_stm31, qlink0_en,
> + qlink0_req, qlink0_wmss, qlink1_en, qlink1_req, qlink1_wmss,
> + spmi_coex, sec_mi2s, spmi_vgi, tgu_ch0, uim1_clk, uim1_data,
> + uim1_present, uim1_reset, uim2_clk, uim2_data, uim2_present,
> + uim2_reset, usb2phy_ac, vsense_trigger ]
> +
> + drive-strength:
> + enum: [2, 4, 6, 8, 10, 12, 14, 16]
> + default: 2
> + description:
> + Selects the drive strength for the specified pins, in mA.
> +
> + bias-pull-down: true
> +
> + bias-pull-up: true
> +
> + bias-disable: true
> +
> + output-high: true
> +
> + output-low: true
> +
> + required:
> + - pins
> + - function
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - '#interrupt-cells'
> + - gpio-controller
> + - '#gpio-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + pinctrl@...0000 {
> + compatible = "qcom,sdx55-pinctrl";
> + reg = <0x0f100000 0x300000>;
> + interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + gpio-controller;
> + #gpio-cells = <2>;
Isn't gpio-ranges a required property? Perhaps that's only a functional
requirement for the hogs to work?
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
Regards,
Bjorn
> + };
> +
> +...
> --
> 2.26.2
>
Powered by blists - more mailing lists