linux-kernel - Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Nov 2020 00:50:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Perry Yuan <Perry.Yuan@...l.com>, hdegoede@...hat.com,
        mgross@...ux.intel.com, mjg59@...f.ucam.org, pali@...nel.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        perry_yuan <Perry.Yuan@...l.com>,
        Limonciello Mario <Mario.Limonciello@...l.com>
Subject: Re: [PATCH]  platform/x86: dell-privacy: Add support for new privacy
 driver

Hi Perry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc2]
[cannot apply to next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b7cbaf59f62f8ab8f157698f9e31642bff525bd0
config: i386-randconfig-r024-20201103 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/cee9f60d7ca58d8f0c6b113c5f7af2dec7e2e27d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721
        git checkout cee9f60d7ca58d8f0c6b113c5f7af2dec7e2e27d
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/platform/x86/dell-laptop.c: In function 'dell_exit':
>> drivers/platform/x86/dell-laptop.c:2289:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
    2289 |     if (!privacy_valid)
         |     ^~
   drivers/platform/x86/dell-laptop.c:2291:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    2291 |  dell_cleanup_rfkill();
         |  ^~~~~~~~~~~~~~~~~~~

vim +/if +2289 drivers/platform/x86/dell-laptop.c

  2280	
  2281	static void __exit dell_exit(void)
  2282	{
  2283		dell_laptop_unregister_notifier(&dell_laptop_notifier);
  2284		debugfs_remove_recursive(dell_laptop_dir);
  2285		if (quirks && quirks->touchpad_led)
  2286			touchpad_led_exit();
  2287		kbd_led_exit();
  2288		backlight_device_unregister(dell_backlight_device);
> 2289	    if (!privacy_valid)
  2290	        led_classdev_unregister(&micmute_led_cdev);
  2291		dell_cleanup_rfkill();
  2292		if (platform_device) {
  2293			platform_device_unregister(platform_device);
  2294			platform_driver_unregister(&platform_driver);
  2295		}
  2296	}
  2297	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32712 bytes)