linux-kernel - Re: [PATCH] drivers: drm: fix msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGt_tNO2uPZk_rA=q-haUSgvcvbHE53gyrOjpdVOqr1J0g@mail.gmail.com>
Date:   Tue, 3 Nov 2020 08:53:24 -0800
From:   Rob Clark <robdclark@...il.com>
To:     dev god <g0d3ph@...il.com>
Cc:     trivial@...nel.org, Sean Paul <sean@...rly.run>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Kalyan Thota <kalyan_t@...eaurora.org>,
        Drew Davenport <ddavenport@...omium.org>,
        Vara Reddy <varar@...eaurora.org>,
        Kuogee Hsieh <khsieh@...eaurora.org>,
        Zheng Bin <zhengbin13@...wei.com>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: drm: fix msm_drv.h warning

Should be fixed by:

https://patchwork.freedesktop.org/patch/397039/?series=83038&rev=1

On Mon, Nov 2, 2020 at 7:44 PM dev god <g0d3ph@...il.com> wrote:
>
> Hi
>
> fix implicit declaration of function error.
>
> >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: error: implicit declaration of function 'msm_dp_display_pre_disable' [-Werror,-Wimplicit-function-declaration]
>                    if (msm_dp_display_pre_disable(priv->dp, drm_enc))
>                        ^
>    drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: note: did you mean 'msm_dp_display_disable'?
>    drivers/gpu/drm/msm/msm_drv.h:420:19: note: 'msm_dp_display_disable' declared here
>    static inline int msm_dp_display_disable(struct msm_dp *dp,
>                      ^
>    1 error generated.
>
> Signed-off-by: Gah0 <g0d3ph@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index f7f5c258b553..52d9a82fb64f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -14,7 +14,7 @@
>  #include <drm/drm_file.h>
>  #include <drm/drm_probe_helper.h>
>
> -#include "msm_drv.h"
> +#include "../../msm_drv.h"
>  #include "dpu_kms.h"
>  #include "dpu_hwio.h"
>  #include "dpu_hw_catalog.h"
> --
> 2.25.1