linux-kernel - Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Nov 2020 18:32:54 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Jim Quinlan <james.quinlan@...adcom.com>,
        linux-pci@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <zajec5@...il.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Jeremy Linton <jeremy.linton@....com>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] PCI: brcmstb: variable is missing proper
 initialization

On Mon, 2020-11-02 at 13:07 -0800, Florian Fainelli wrote:
> 
> On 11/2/2020 12:57 PM, Jim Quinlan wrote:
> > The variable 'tmp' is used multiple times in the brcm_pcie_setup()
> > function.  One such usage did not initialize 'tmp' to the current value of
> > the target register.  By luck the mistake does not currently affect
> > behavior;  regardless 'tmp' is now initialized properly.
> > 
> > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
> > Suggested-by: Rafał Miłecki <zajec5@...il.com>
> > Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>

Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)