linux-kernel - Re: [PATCH v4.9..v4.19] rtc: rx8010: don't modify the global rtc ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Nov 2020 19:48:23 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v4.9..v4.19] rtc: rx8010: don't modify the global rtc ops

On Tue, Nov 03, 2020 at 06:29:01PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> The way the driver is implemented is buggy for the (admittedly unlikely)
> use case where there are two RTCs with one having an interrupt configured
> and the second not. This is caused by the fact that we use a global
> rtc_class_ops struct which we modify depending on whether the irq number
> is present or not.
> 
> Fix it by using two const ops structs with and without alarm operations.
> While at it: not being able to request a configured interrupt is an error
> so don't ignore it and bail out of probe().
> 
> Fixes: ed13d89b08e3 ("rtc: Add Epson RX8010SJ RTC driver")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: stable@...r.kernel.org
> Link: https://lore.kernel.org/r/20200914154601.32245-2-brgl@bgdev.pl
> ---
>  drivers/rtc/rtc-rx8010.c | 24 +++++++++++++++++-------
>  1 file changed, 17 insertions(+), 7 deletions(-)

Now queued up, thanks!

greg k-h