linux-kernel - Re: [PATCH] xfs: Drop useless comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201103185023.GJ7123@magnolia>
Date:   Tue, 3 Nov 2020 10:50:23 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Fengfei Xi <fengfei_xi@....com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: Drop useless comments

On Mon, Nov 02, 2020 at 08:03:16AM +0800, Fengfei Xi wrote:
> The names of functions xfs_buf_get_maps and _xfs_buf_free_pages

xfs_buf_get_maps?  I don't see any changes for that function...?

--D

> can fully express their roles. So their comments are redundant.
> We could drop them entirely.
> 
> Signed-off-by: Fengfei Xi <fengfei_xi@....com>
> ---
>  fs/xfs/xfs_buf.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 4e4cf91..2aeed30 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -197,9 +197,6 @@
>  	return 0;
>  }
>  
> -/*
> - *	Frees b_pages if it was allocated.
> - */
>  static void
>  xfs_buf_free_maps(
>  	struct xfs_buf	*bp)
> @@ -297,9 +294,6 @@
>  	return 0;
>  }
>  
> -/*
> - *	Frees b_pages if it was allocated.
> - */
>  STATIC void
>  _xfs_buf_free_pages(
>  	xfs_buf_t	*bp)
> -- 
> 1.9.1
>