linux-kernel - RE: [PATCH] ASoC: rt715:add Mic Mute LED control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR19MB2636311108BDD43DF8DE8E89FA110@DM6PR19MB2636.namprd19.prod.outlook.com>
Date:   Tue, 3 Nov 2020 19:01:06 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@...l.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "Yuan, Perry" <Perry.Yuan@...l.com>,
        "oder_chiou@...ltek.com" <oder_chiou@...ltek.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tiwai@...e.com" <tiwai@...e.com>
Subject: RE: [PATCH] ASoC: rt715:add Mic Mute LED control support

> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: Tuesday, November 3, 2020 12:32
> To: Limonciello, Mario
> Cc: Pierre-Louis Bossart; Yuan, Perry; oder_chiou@...ltek.com; alsa-
> devel@...a-project.org; lgirdwood@...il.com; linux-kernel@...r.kernel.org;
> tiwai@...e.com
> Subject: Re: [PATCH] ASoC: rt715:add Mic Mute LED control support
> 
> On Tue, Nov 03, 2020 at 06:04:49PM +0000, Limonciello, Mario wrote:
> 
> > I don't think it came through in the commit message, but I wanted to mention
> > in the system that prompted this software does not control the LED.  The LED
> > is actually controlled by hardware, but has circuitry to delay the hardware
> > mute until software mute is complete to avoid any "popping noises".
> 
> Ah, this doesn't correspond to the description at all.
> 
> > The flow is:
> > User presses mute key, dell-wmi receives event, passes to dell-privacy-wmi.
> > This emits to userspace as KEY_MICMUTE.  Userspace processes it and via UCM
> > switches get toggled.  The codec driver (or subsystem perhaps) will use LED
> > trigger to notify to change LED.  This gets picked up by dell-privacy-acpi.
> 
> > dell-privacy-acpi doesn't actually change LED, but notifies that SW mute was
> > done.
> 
> > If none of that flow was used the LED and mute function still work, but
> there
> > might be the popping noise.
> 
> With a timeout so that if things get lost somewhere then the mute button
> is still functional, 

Exactly.

> or can userspace block mute?  Also what happens if
> userspace tries to set the state without having done anything about
> muting, will it trigger the hardware level mute as though the key had
> been pressed?

No, the hardware level mute is tied to the actual key.  If the software
mute is set, the LED won't change.  In this case this is what would happen:
1) Kcontrol flips
2) Codec / Subsystem notifies dell-privacy-acpi
3) Dell-privacy-acpi notifies SW mute is done
4) Nothing happens to HW mute / LED

There is functionality in dell-privacy to track the state of the HW mute
so later on this scenario can be expanded upon to emit an event from
dell-privacy that userspace can see and show a message along the lines of

"SW was muted, but HW mute still isn't set, press FN+F2 to set it".

That's follow up stuff for after the initial patch series is landed.