linux-kernel - Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7aef297e-cbee-6f04-9d74-82cf97579880@gmail.com>
Date:   Mon, 2 Nov 2020 18:12:32 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Pavana Sharma <pavana.sharma@...i.com>, andrew@...n.ch
Cc:     ashkan.boldaji@...i.com, davem@...emloft.net,
        gregkh@...uxfoundation.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, marek.behun@....cz,
        netdev@...r.kernel.org, vivien.didelot@...il.com
Subject: Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode



On 11/2/2020 5:34 PM, Pavana Sharma wrote:
>> How many times have i asked for you to add kerneldoc for this new
>> value? How many times have you not done so?
> 
> I have added kerneldoc comment for the new value added.
> 
>> NACK.
> 
>> If you don't understand a comment, please ask.
> 
> Ok, explain what do you expect by that comment.

What Andrew wants you to do is add a comment like this:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88
-- 
Florian