linux-kernel - Re: [PATCH 0/2] prevent potential access of uninitialized members in can_rcv() and canfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <794cd63d-b0cb-2cc9-199c-d18724852db6@pengutronix.de>
Date:   Tue, 3 Nov 2020 23:17:40 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Anant Thazhemadam <anant.thazhemadam@...il.com>,
        socketcan@...tkopp.net, davem@...emloft.net, kuba@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] prevent potential access of uninitialized members in
 can_rcv() and canfd_rcv()

On 11/3/20 10:39 PM, Anant Thazhemadam wrote:
> In both can_rcv(), and canfd_rcv(), when skb->len = 0, cfd->len 
> (which is uninitialized) is accessed by pr_warn_once().
> 
> Performing the validation check for cfd->len separately, after the 
> validation check for skb->len is done, resolves this issue in both 
> instances, without compromising the degree of detail provided in the
> log messages.
> 
> Anant Thazhemadam (2):
>   can: af_can: prevent potential access of uninitialized member in
>     can_rcv()
>   can: af_can: prevent potential access of uninitialized member in
>     canfd_rcv()
> 
>  net/can/af_can.c | 38 ++++++++++++++++++++++++++++----------
>  1 file changed, 28 insertions(+), 10 deletions(-)
> 

Applied both to linux-can/testing

Tnx,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)