linux-kernel - Re: [PATCH v2 4/4] compat: remove some compat entry points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2m_VYiTY7Rg+3kfohPc2W=jHLh7dF4aVffSpwMa7C=4Q@mail.gmail.com>
Date:   Tue, 3 Nov 2020 10:45:54 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Brian Gerst <brgerst@...il.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Ingo Molnar <mingo@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>, kexec@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] compat: remove some compat entry points

On Tue, Nov 3, 2020 at 9:38 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Mon, Nov 02, 2020 at 01:31:51PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > These are all handled correctly when calling the native
> > system call entry point, so remove the special cases.
>
> Ok, this is where you do it.  I think this belongs into the main
> patches.

I had it there originally, I guess I should have left it there ;-)

When I changed it, I was considering to do the same for additional
syscalls that have very small differences now (timer_create,
rt_sigqueueinfo, rt_sigpending, recvmsg, sendmsg) and use
in_compat_syscall() there, but then I decided against that.

In the end, I did like the split, as I found the smaller three
patches that contain the real change easier to review, and
it turns the larger patch at the end into a more obvious
transformation.

      Arnd