linux-kernel - drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103100037.GE12347@kadam>
Date:   Tue, 3 Nov 2020 13:00:37 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Tamizh Chelvam <tamizhr@...eaurora.org>
Cc:     lkp@...el.com, Dan Carpenter <error27@...il.com>,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Kalle Valo <kvalo@...eaurora.org>
Subject: drivers/net/wireless/ath/ath10k/mac.c:9125
 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3cea11cd5e3b00d91caf0b4730194039b45c5891
commit: 7b2531d93bac6bea67e9c7f49901e9e8796d6d57 ath10k: Add new api to support TID specific configuration
config: x86_64-randconfig-m031-20201102 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.

vim +/ret +9125 drivers/net/wireless/ath/ath10k/mac.c

7b2531d93bac6be Tamizh Chelvam  2020-08-19  9089  static int ath10k_mac_op_set_tid_config(struct ieee80211_hw *hw,
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9090  					struct ieee80211_vif *vif,
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9091  					struct ieee80211_sta *sta,
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9092  					struct cfg80211_tid_config *tid_config)
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9093  {
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9094  	struct ath10k *ar = hw->priv;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9095  	struct ath10k_vif *arvif = (void *)vif->drv_priv;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9096  	struct ath10k_mac_iter_tid_conf_data data = {};
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9097  	struct wmi_per_peer_per_tid_cfg_arg arg = {};
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9098  	int ret, i;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9099  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9100  	mutex_lock(&ar->conf_mutex);
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9101  	arg.vdev_id = arvif->vdev_id;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9102  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9103  	memset(arvif->tid_conf_changed, 0, sizeof(arvif->tid_conf_changed));
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9104  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9105  	for (i = 0; i < tid_config->n_tid_conf; i++) {
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9106  		ret = ath10k_mac_parse_tid_config(ar, sta, vif,
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9107  						  &tid_config->tid_conf[i],
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9108  						  &arg);
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9109  		if (ret)
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9110  			goto exit;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9111  	}
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9112  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9113  	if (sta)
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9114  		goto exit;
                                                                ^^^^^^^^^^

7b2531d93bac6be Tamizh Chelvam  2020-08-19  9115  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9116  	ret = 0;
                                                        ^^^^^^^^
Probably just move this to the "int ret = 0;" start of the function?

7b2531d93bac6be Tamizh Chelvam  2020-08-19  9117  	data.curr_vif = vif;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9118  	data.ar = ar;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9119  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9120  	ieee80211_iterate_stations_atomic(hw, ath10k_mac_vif_stations_tid_conf,
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9121  					  &data);
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9122  
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9123  exit:
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9124  	mutex_unlock(&ar->conf_mutex);
7b2531d93bac6be Tamizh Chelvam  2020-08-19 @9125  	return ret;
7b2531d93bac6be Tamizh Chelvam  2020-08-19  9126  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31397 bytes)