linux-kernel - [kbuild] sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201103105713.GC18329@kadam>
Date:   Tue, 3 Nov 2020 13:57:13 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Stephen Boyd <sboyd@...nel.org>
Cc:     lkp@...el.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: [kbuild] sound/soc/codecs/wcd934x.c:1571:9: warning: Identical
 condition 'ret', second condition is always false

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  master
head:   b7cbaf59f62f8ab8f157698f9e31642bff525bd0
commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
    return ret;
           ^
   sound/soc/codecs/wcd934x.c:1568:6: note: first condition
    if (ret)
        ^
   sound/soc/codecs/wcd934x.c:1571:9: note: second condition
    return ret;
           ^

vim +/ret +1571 sound/soc/codecs/wcd934x.c

a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1561  
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1562  	ret = wcd934x_set_prim_interpolator_rate(dai, (u8)rate_val,
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1563  						 sample_rate);
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1564  	if (ret)
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1565  		return ret;
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1566  	ret = wcd934x_set_mix_interpolator_rate(dai, (u8)rate_val,
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1567  						sample_rate);
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1568  	if (ret)
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1569  		return ret;
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1570  
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 @1571  	return ret;
                                                        ^^^^^^^^^^^
Just "return 0;"

a61f3b4f476eceb Srinivas Kandagatla 2019-12-19  1572  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org 
_______________________________________________
kbuild mailing list -- kbuild@...ts.01.org
To unsubscribe send an email to kbuild-leave@...ts.01.org